Update appname in crash logs (#969)

tchapgouv · Sep 14, 2023 · 31796d9 · 31796d9
1 parent 33cf7a9
commit 31796d9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/changelog.d/969.misc b/changelog.d/969.misc
@@ -0,0 +1 @@
+Update appname in crash logs
diff --git a/vector/src/main/java/im/vector/app/core/resources/AppNameProvider.kt b/vector/src/main/java/im/vector/app/core/resources/AppNameProvider.kt
@@ -40,7 +40,7 @@ class DefaultAppNameProvider @Inject constructor(private val context: Context) :
             appName
         } catch (e: Exception) {
             Timber.e(e, "## AppNameProvider() : failed")
-            "ElementAndroid"
+            "TchapAndroid"
         }
     }
 }
diff --git a/vector/src/main/java/im/vector/app/features/rageshake/VectorUncaughtExceptionHandler.kt b/vector/src/main/java/im/vector/app/features/rageshake/VectorUncaughtExceptionHandler.kt
@@ -20,6 +20,7 @@ import android.content.SharedPreferences
 import android.os.Build
 import androidx.core.content.edit
 import im.vector.app.core.di.DefaultPreferences
+import im.vector.app.core.resources.AppNameProvider
 import im.vector.app.core.resources.VersionCodeProvider
 import im.vector.app.features.version.VersionProvider
 import org.matrix.android.sdk.api.Matrix
@@ -36,6 +37,7 @@ class VectorUncaughtExceptionHandler @Inject constructor(
         private val bugReporter: BugReporter,
         private val versionProvider: VersionProvider,
         private val versionCodeProvider: VersionCodeProvider,
+        private val appNameProvider: AppNameProvider,
 ) : Thread.UncaughtExceptionHandler {
 
     // key to save the crash status
@@ -67,12 +69,12 @@ class VectorUncaughtExceptionHandler @Inject constructor(
             putBoolean(PREFS_CRASH_KEY, true)
         }
         val b = StringBuilder()
-        val appName = "Element" // TODO Matrix.getApplicationName()
+        val appName = appNameProvider.getAppName()
 
-        b.append(appName + " Build : " + versionCodeProvider.getVersionCode() + "\n")
+        b.append("$appName Build : ${versionCodeProvider.getVersionCode()}\n")
         b.append("$appName Version : ${versionProvider.getVersion(longFormat = true)}\n")
         b.append("SDK Version : ${Matrix.getSdkVersion()}\n")
-        b.append("Phone : " + Build.MODEL.trim() + " (" + Build.VERSION.INCREMENTAL + " " + Build.VERSION.RELEASE + " " + Build.VERSION.CODENAME + ")\n")
+        b.append("Phone : ${Build.MODEL.trim()} (${Build.VERSION.INCREMENTAL} ${Build.VERSION.RELEASE} ${Build.VERSION.CODENAME})\n")
 
         b.append("Memory statuses \n")