Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new doc page 'change_api' and minor changes #241

Merged
merged 2 commits into from
Jul 13, 2023
Merged

added a new doc page 'change_api' and minor changes #241

merged 2 commits into from
Jul 13, 2023

Conversation

rsoika
Copy link
Collaborator

@rsoika rsoika commented Jul 11, 2023

I have generated and updated the new doc/ folder by calling the script /src/site$ ./build-html.sh

In a later stage we can discuss if you want to change the left navigation. Currently I just added the link to the new doc page into the page /docs/odfdom/index.html

@svanteschubert
Copy link
Contributor

Hallo Ralph,

there is already a more sophisticated change API, which allows real-time collaboration: https://tdf.github.io/odftoolkit/odfdom/operations/operations.html

Therefore - to avoid confusion - I would call the API you documented the search-and-replace API (or somehow related, like search-replace, etc.).

What you think? Open for some call, but to leave in in 45min till rest of day.

Cheers,
Svante

@svanteschubert svanteschubert self-requested a review July 13, 2023 11:05
@rsoika
Copy link
Collaborator Author

rsoika commented Jul 13, 2023

I renamed the document and the wording

Copy link
Contributor

@svanteschubert svanteschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very much appreciated! Thank you, Ralph!

@svanteschubert svanteschubert merged commit f5c807f into tdf:master Jul 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants