Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: base all permission need no resourceId #1175

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: base all permission need no resourceId #1175

merged 1 commit into from
Dec 19, 2024

Conversation

tea-artist
Copy link
Contributor

No description provided.

@tea-artist tea-artist requested a review from boris-w December 19, 2024 13:31
@tea-artist tea-artist added the preview This issue is already ready for preview label Dec 19, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12413702454

Details

  • 9 of 12 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feat/token-permission at 81.417%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/auth/guard/permission.guard.ts 9 12 75.0%
Totals Coverage Status
Change from base Build 12411042005: 81.4%
Covered Lines: 28876
Relevant Lines: 35467
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1175.sealosgzg.site

@tea-artist tea-artist merged commit bcbb977 into develop Dec 19, 2024
16 checks passed
@tea-artist tea-artist deleted the feat/token-permission branch December 19, 2024 14:24
@github-actions GitHub Actions
Copy link

🧹 Preview Environment Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-w boris-w Awaiting requested review from boris-w

Assignees
No one assigned
Labels
preview This issue is already ready for preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tea-artist @coveralls