Skip to content

Commit

Permalink
[update] allow php version 8.3 (#20)
Browse files Browse the repository at this point in the history
  • Loading branch information
lukadschaak authored Nov 29, 2024
1 parent f219efc commit 1dd9cae
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: PHP Setup
uses: shivammathur/setup-php@v2
with:
php-version: 8.2
php-version: 8.3

- name: Validate composer.json
run: composer validate --strict
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ jobs:
dependencies: "highest" # Pimcore 11.*
- php-version: "8.2"
dependencies: "highest" # Pimcore 11.*
- php-version: "8.3"
dependencies: "highest" # Pimcore 11.*

steps:
- name: Git Checkout
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.3.0

### Changes:

- Allow PHP 8.3

## 1.2.0

### Features:
Expand Down
2 changes: 1 addition & 1 deletion compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
timeout: 10s

php:
image: pimcore/pimcore:php8.2-latest
image: pimcore/pimcore:php8.3-latest
volumes:
- ./:/var/www/html/
environment:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
},
"require": {
"php": "~8.1.0 || ~8.2.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"pimcore/pimcore": "^10.5.1 || ^11.0",
"symfony/console": "^5.4 || ^6.0",
"symfony/finder": "^5.4 || ^6.0",
Expand Down
2 changes: 0 additions & 2 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@ parameters:

bootstrapFiles:
- vendor/pimcore/pimcore/stubs/dynamic-constants.php

checkGenericClassInNonGenericObjectType: false

0 comments on commit 1dd9cae

Please sign in to comment.