feat(footer): implement footer component #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for portal-ascepa ready! ✅ Preview Built with commit 9c936cc. |
|
FelipeDuarteLuna
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Boa Tarde Guerreiro, Firme ?
Sua implementação funcionou legal, mas precisa realizar 2 ajustes.
I. Utilizar o Tokens de margens e cor;
II. Ajuste o Media Queries, com px não fica renderizando conforme o tamanho.
Werisu
reviewed
Sep 23, 2024
|
|
||
| footer { | ||
| text-align: center; | ||
| padding: 20px; |
Werisu
reviewed
Sep 23, 2024
| @@ -0,0 +1,10 @@ | |||
| <footer id="footer"> | |||
There was a problem hiding this comment.
adicionar a class p-20px e mt-20px
Werisu
reviewed
Sep 23, 2024
| text-align: center; | ||
| padding: 20px; | ||
| background-color: #f8f8f8; | ||
| margin-top: 20px; |
Werisu
reviewed
Sep 23, 2024
| footer { | ||
| text-align: center; | ||
| padding: 20px; | ||
| background-color: #f8f8f8; |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Criação do componente Footer com layouts para Web e Mobile(responsivo) de acordo com template definido no figma
Desktop
Mobile
Tipo da alteração
feat: Uma nova funcionalidade
Checklist
Outras observações