fix: reindex mongo error when datamodel change

[AlvaroVega]

Related with PR #2211

https://www.mongodb.com/docs/manual/reference/method/db.collection.createIndex/

[AlvaroVega]

Maybe IndexKeySpecsConflict happens when DM is changed and previous index exists with another key.
Make sense @fgalan @Madhu-NEC ?

[AlvaroVega]

maybe related #2291 ?

[fgalan]

Maybe IndexKeySpecsConflict happens when DM is changed and previous index exists with another key. Make sense @fgalan @Madhu-NEC ?

It seems the code was already prepared for re-indexing. I understand that it was not working until you have added the IndexKeySpecsConflict exception to the catch clause.

Maybe in the past (i.e. old versions of MongoDB or the driver) the exception was IndexOptionsConflict so it was working that time but not now? In this case, I think the strategy of adding the new exception (IndexKeySpecsConflict) is a good idea.

[AlvaroVega]

Maybe IndexKeySpecsConflict happens when DM is changed and previous index exists with another key. Make sense @fgalan @Madhu-NEC ?

It seems the code was already prepared for re-indexing. I understand that it was not working until you have added the IndexKeySpecsConflict exception to the catch clause.

Maybe in the past (i.e. old versions of MongoDB or the driver) the exception was IndexOptionsConflict so it was working that time but not now? In this case, I think the strategy of adding the new exception (IndexKeySpecsConflict) is a good idea.

IMHO:
IndexOptionsConflict -> when the same index (name and keys) already exits
IndexKeySpecsConflict -> when an index with the same name but different keys (i.e. DM was changed) already exist.

Anyway, this kind of check is weak, since a change of mongo driver literals would hide these conflicts. It would be nice to relay on generic index conflict by mongo.

[fgalan]

LGTM