Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if auth server revoke the refresh token, refreshToken() method call … #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ireshmw
Copy link

@ireshmw ireshmw commented Nov 20, 2021

infinite loop of refreshToken() method calls if auth server revokes the refresh token.

@okrad
Copy link
Collaborator

okrad commented Dec 13, 2021

Hi @ireshmw, the current code looks correct to me, but I guess I'm not taking into consideration some edge cases.
Can you explain in which situation you get the infinite loop?

@ireshmw
Copy link
Author

ireshmw commented Dec 14, 2021

Hi @okrad
When you revoke the refresh token and auth token manually from your OAuth server, this error occurs. So I have a Keycloak auth server and when I revoke all the sessions, I faced this issue,

in this case most important modifications was to me is replacing tokenStorage.deleteToken(scopes ?? []); with the tokenStorage.deleteAllTokens() , because tokenStorage.deleteToken(scopes ?? []); will not clear the refresh token completely so it will try to refresh using the existing refresh token and it keep getting fails because when I revoke the refresh token from the server.

I think you can check it if you try to recreate this problem as I mentioned.

@okrad
Copy link
Collaborator

okrad commented Dec 29, 2021

I think what's most important to understand is why deleteToken doesn't clear the refresh token...
Could it be that the value of the scopes parameter when the deleteToken is called doesn't match with an actual stored token?

@scognito
Copy link

I 'm having the same issue of infinite loop using keycloak. It happens randomly, maybe some automatic rule revoke something.

pdivita pushed a commit to pdivita/oauth2_client that referenced this pull request Feb 22, 2022
…he spesso crasha (errore 500) quando si richiede un refresh token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants