feat: Allow specifying additional TGW routes in attached VPCs #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds parameter `tgw_additional_vpc_cidrs` to the `vpc_attachments` map that enables adding additional `aws_route` resources that send traffic across the TGW peering connection. Changes the name of the existing `aws_route` resource from `this` since there are now more than one in the state file.
|
NOTE: this change has the same bootstrapping problem as #111, but it works correctly when the VPC resources are configured ahead of time (or in a separate state file as we do in our terraform) |
|
Hi @antonbabenko could you please take a look |
|
Good morning. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Hi @antonbabenko could you please take a look |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Hi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds parameter
tgw_additional_vpc_cidrsto thevpc_attachmentsmap that enables adding additionalaws_routeresources that send traffic across the TGW VPC attachment.Changes the name of the existing
aws_routeresource fromthissince there are now more than one in the state file.Motivation and Context
In our environment we have two CIDR blocks that need to transit from the VPC across the TGW network:
10.0.0.0/8and172.16.0.0/12. Unfortunately this is not possible to do with the module as it is today.With this change we can add
aws_routeentries for both CIDR blocks to our VPC route tables.Breaking Changes
This change increments the minimum required terraform version to 1.1 in order to take advantage of
movedblocks.In order to implement this I had to add a second
aws_routeresource because the existing one is keyed only on route table ID which is no longer a unique value for route resources.Commonly accepted Terraform style rules indicate that
thisis only an acceptable resource name if it is the only one of its type in a module. Since there are now twoaws_routeresources, I changed the name of the existingthisresource todestination_cidrso that this style rule is still valid.While I personally feel that the overwhelming majority of module users should already be using a version equal to or greater than Terraform 1.1, if bumping this requirement is undesirable I would fine with reverting the resource rename and leaving the minimum required version as is.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request