Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for conditional for custom role member #217

Conversation

ps-occrp
Copy link

Add support for conditional for custom role member

@ps-occrp ps-occrp requested a review from a team as a code owner April 18, 2024 13:52
@ps-occrp
Copy link
Author

@imrannayer or @apeabody can you please review this PR?

@imrannayer
Copy link
Collaborator

@ps-occrp thx for the PR. Is it possible if you can follow the same pattern we have for other modules? See project IAM example

@ps-occrp
Copy link
Author

@imrannayer Can you check now?

@imrannayer
Copy link
Collaborator

@ps-occrp can u plz add a condition in example so we can make it part of integration test?

@imrannayer
Copy link
Collaborator

/gcbrun

@ps-occrp
Copy link
Author

@imrannayer can this be merged?

@imrannayer
Copy link
Collaborator

@bharathkkb can u plz review? I dont have permission on this repo.

@ps-occrp
Copy link
Author

@bharathkkb Can this be merged?

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 16, 2024
@github-actions github-actions bot closed this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants