Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Change project as a required input variable #221

Closed
wants to merge 2 commits into from

Conversation

JanCVanB
Copy link

@JanCVanB JanCVanB commented Jul 2, 2024

The service_accounts_iam module uses var.project raw in multiple places, with no way of inferring a project ID. The default is misleading, because the module crashes with it.

See https://github.com/terraform-google-modules/terraform-google-iam/blob/master/modules/service_accounts_iam/main.tf#L33-L51

The `service_accounts_iam` module uses `var.project` raw in multiple places, with no way of inferring a project ID. The default is misleading, because the module crashes with it.
@JanCVanB JanCVanB requested a review from a team as a code owner July 2, 2024 20:24
@imrannayer imrannayer changed the title Correct that project is a required input variable fix!: Change project as a required input variable Aug 21, 2024
@imrannayer
Copy link
Collaborator

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @JanCVanB!

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/service_accounts_iam/README.md /tmp/tmp.a9qY6WQIxA/generate_docs/workspace/modules/service_accounts_iam/README.md
[53](https://github.com/terraform-google-modules/terraform-google-iam/actions/runs/10706792069/job/29685307413?pr=221#step:5:54)c53
< | project | Project to add the IAM policies/bindings | `string` | `""` | no |
---
> | project | ID of target project for the IAM policies/bindings | `string` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

Copy link

github-actions bot commented Nov 3, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Nov 3, 2024
@github-actions github-actions bot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants