Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Run treefmt in CI #19

Closed
wants to merge 11 commits into from
Closed

Run treefmt in CI #19

wants to merge 11 commits into from

Conversation

tuxiqae
Copy link
Contributor

@tuxiqae tuxiqae commented Oct 21, 2023

No description provided.

@tuxiqae
Copy link
Contributor Author

tuxiqae commented Oct 21, 2023

@mdarocha It seems to work now, I would honestly move the shell declaration into a shell.nix file and use that, also I would use Cachix in order to shorten the package fetch times

The following commits 1dc3f57eb5bdb3e30d68ab919a7399b162dd384e, 3033512ea06dc15d14db0a9d6385a09a11790bb8, and fed4efd0c94f336bea2fb4e24fd4e1fa1bf47936 were added in order to verify that the CI indeed passes when no diffs are found, will be dropped later.
Please do not merge it without dropping those commits, as I'd rather not have all of those linted codelines on me only since I was the one who ran treefmt last, especially since I'm not maintainer.

P.S. the commits in which the formatting will be done can be ignored in git blame: https://akrabat.com/ignoring-revisions-with-git-blame/

@tuxiqae tuxiqae marked this pull request as draft October 21, 2023 13:51
@mrVanDalo
Copy link
Member

So this will create commits, if someone forgets to run treefmt? Or will it reject pushes and pull requests?

@tuxiqae
Copy link
Contributor Author

tuxiqae commented Oct 22, 2023

@mrVanDalo

So this will create commits, if someone forgets to run treefmt? Or will it reject pushes and pull requests?

The validations in the CI will fail and a merge would not be allowed

@mdarocha
Copy link
Contributor

Looks good! However, I'd prefer using flakes and nix run instead of nix-shell, so that the nixpkgs version defined in flake.lock is used.

@tuxiqae
Copy link
Contributor Author

tuxiqae commented Oct 25, 2023

Looks good! However, I'd prefer using flakes and nix run instead of nix-shell, so that the nixpkgs version defined in flake.lock is used.

Thanks!
For sure, I'm just a Nix noob, so I didn't try doing it by myself

@mrVanDalo
Copy link
Member

mrVanDalo commented Jan 3, 2024

I'll archive this repository now. I created an Issue in the new repository to not forget this pull request. terranix/terranix.github.io#10 < please comment in this issue in the future.

@mrVanDalo mrVanDalo closed this Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants