Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Zachary Prince <zachmprince@gmail.com>
Co-authored-by: John Stilley <1831479+john-science@users.noreply.github.com>
  • Loading branch information
3 people authored Oct 14, 2024
1 parent a987c73 commit 17a77d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions armi/reactor/tests/test_blocks.py
Original file line number Diff line number Diff line change
Expand Up @@ -2052,9 +2052,7 @@ def test_getPinCoords(self):
nPins = self.HexBlock.getNumPins()
side = hexagon.side(blockPitch)
xyz = self.HexBlock.getPinCoordinates()
x = xyz[:, 0]
y = xyz[:, 1]
z = xyz[:, 2]
x, y, z = xyz.T
self.assertAlmostEqual(
y[1], y[2]
) # first two pins should be side by side on top.
Expand Down
4 changes: 1 addition & 3 deletions armi/reactor/tests/test_hexBlockRotate.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
from armi.reactor.blocks import HexBlock
from armi.reactor.components import Component
from armi.reactor.grids import MultiIndexLocation, CoordinateLocation
from armi.utils import iterables
from armi.reactor.tests.test_blocks import loadTestBlock, NUM_PINS_IN_TEST_BLOCK
from armi.utils import iterables


class HexBlockRotateTests(unittest.TestCase):
Expand Down Expand Up @@ -121,7 +121,6 @@ def test_pinRotationLocations(self):
.. test:: HexBlock.getPinLocations is consistent with rotation.
:id: T_ARMI_ROTATE_HEX_PIN_LOCS
:tests: R_ARMI_ROTATE_HEX
"""
preRotation = self.BASE_BLOCK.getPinLocations()
for nRotations in range(-10, 10):
Expand Down Expand Up @@ -229,7 +228,6 @@ class EmptyBlockRotateTest(unittest.TestCase):
"""Rotation tests on an empty hexagonal block.
Useful for enforcing rotation works on blocks without pins.
"""

def setUp(self):
Expand Down

0 comments on commit 17a77d5

Please sign in to comment.