-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Component Axial Linking Approach #1376
Draft
albeanth
wants to merge
29
commits into
terrapower:main
Choose a base branch
from
albeanth:addNewCompAxialLinkMthd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8174fbe
WIP: have the pin groupings working.
albeanth 0a5b205
adjusting blueprints to have for block grids
albeanth 02c5685
resolve multiple axial linkage w/ spatialLocator
albeanth e789aa5
add check to skip non-pinned assemblies
albeanth cd3a1c7
remove requirement for consistent pin groupings
albeanth db8bbd0
rm unused methods
albeanth 8098453
rm unused instance variable
albeanth 1a1b347
clean up a terrible docstring
albeanth 115c3a9
retain original behavior for multiple linkage
albeanth 7f4ca22
improve docstrings
albeanth cf62f02
make determineLinked and checkOverlap static methods
albeanth 4eeef7a
organizing and adding new tests
albeanth ee9e252
adding test coverage for grid-based linking
albeanth 169edc4
rm duplicate test
albeanth 0d1a5b9
enable multiple axial linkage during set up
albeanth ab7cdb5
add case3 to TestDetermineLinked
albeanth 1259c1f
add additional complexities to test blueprints
albeanth 04a4e24
fix broken unit test
albeanth 9c795c8
Merge branch 'main' into addNewCompAxialLinkMthd
albeanth bd9bfa6
Update ztop for blocks that don't have any solid components
keckler 4f1dd9c
Add test on assembly that has a purely fluid block
keckler 73e7795
Remove use of walrus operator
keckler 63e37fd
Revert "Remove use of walrus operator"
keckler 25f8e9f
Revert "Add test on assembly that has a purely fluid block"
keckler 989a43b
Revert "Update ztop for blocks that don't have any solid components"
keckler e3b4765
Explicitly raise an error if assemblies include blocks without solid …
keckler 836be51
Add test on new check
keckler 0c995d0
Merge branch 'main' of https://github.com/terrapower/armi into addNew…
keckler 41127a2
Merge branch 'main' into addNewCompAxialLinkMthd
albeanth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give a little more detail so users don't have to dig into the source code. E.g. "...is constructed improperly for use with the axial expansion changer; i.e., assemblies cannot have intermediate blocks void of a solid component. Consider using....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well ideally there would be some documentation that outlines how to use the axial expansion capability ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah! Yeah yeah.... very true....