Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Component Axial Linking Approach #1376

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Add New Component Axial Linking Approach #1376

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
8174fbe
WIP: have the pin groupings working.
albeanth Jul 26, 2023
0a5b205
adjusting blueprints to have for block grids
albeanth Jul 27, 2023
02c5685
resolve multiple axial linkage w/ spatialLocator
albeanth Jul 27, 2023
e789aa5
add check to skip non-pinned assemblies
albeanth Jul 27, 2023
cd3a1c7
remove requirement for consistent pin groupings
albeanth Jul 28, 2023
db8bbd0
rm unused methods
albeanth Jul 31, 2023
8098453
rm unused instance variable
albeanth Jul 31, 2023
1a1b347
clean up a terrible docstring
albeanth Jul 31, 2023
115c3a9
retain original behavior for multiple linkage
albeanth Jul 31, 2023
7f4ca22
improve docstrings
albeanth Jul 31, 2023
cf62f02
make determineLinked and checkOverlap static methods
albeanth Jul 31, 2023
4eeef7a
organizing and adding new tests
albeanth Aug 3, 2023
ee9e252
adding test coverage for grid-based linking
albeanth Aug 4, 2023
169edc4
rm duplicate test
albeanth Aug 4, 2023
0d1a5b9
enable multiple axial linkage during set up
albeanth Aug 4, 2023
ab7cdb5
add case3 to TestDetermineLinked
albeanth Aug 7, 2023
1259c1f
add additional complexities to test blueprints
albeanth Aug 7, 2023
04a4e24
fix broken unit test
albeanth Aug 7, 2023
9c795c8
Merge branch 'main' into addNewCompAxialLinkMthd
albeanth Sep 6, 2023
bd9bfa6
Update ztop for blocks that don't have any solid components
keckler Oct 9, 2023
4f1dd9c
Add test on assembly that has a purely fluid block
keckler Oct 9, 2023
73e7795
Remove use of walrus operator
keckler Oct 9, 2023
63e37fd
Revert "Remove use of walrus operator"
keckler Oct 10, 2023
25f8e9f
Revert "Add test on assembly that has a purely fluid block"
keckler Oct 10, 2023
989a43b
Revert "Update ztop for blocks that don't have any solid components"
keckler Oct 10, 2023
e3b4765
Explicitly raise an error if assemblies include blocks without solid …
keckler Oct 10, 2023
836be51
Add test on new check
keckler Oct 10, 2023
0c995d0
Merge branch 'main' of https://github.com/terrapower/armi into addNew…
keckler Feb 25, 2024
41127a2
Merge branch 'main' into addNewCompAxialLinkMthd
albeanth Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 43 additions & 9 deletions armi/reactor/blueprints/tests/test_blockBlueprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,39 @@
id: 0.0
od: 0.7
latticeIDs: [1]
clad: # same args as test_blocks (except mult)
feed:
shape: Circle
material: UZr
Tinput: 25.0
Thot: 600.0
id: 0.0
od: 0.7
latticeIDs: [2]
slug:
shape: Circle
material: UZr
Tinput: 25.0
Thot: 600.0
id: 0.0
od: 0.7
latticeIDs: [3]
clad: &component_clad
# same args as test_blocks (except mult)
shape: Circle
material: HT9
Tinput: 25.0
Thot: 450.0
id: .77
od: .80
latticeIDs: [1,2]
latticeIDs: [1]
clad_feed:
<<: *component_clad
flags: CLAD FEED
latticeIDs: [2]
clad_slug:
<<: *component_clad
flags: CLAD SLUG
latticeIDs: [3]
coolant:
shape: DerivedShape
material: Sodium
Expand Down Expand Up @@ -72,14 +97,23 @@
id: 0.0
od: 0.67
latticeIDs: [1]
clad:
test:
shape: Circle
material: HT9
material: UZr
Tinput: 25.0
Thot: 450.0
id: .77
od: .80
latticeIDs: [1,2]
Thot: 600.0
id: 0.0
od: 0.67
latticeIDs: [2,3]
clad: *component_clad
clad_feed:
# should be clad_test with CLAD TEST
# flags, but for testing in
# test_axialExpansionChanger.TestRetrieveAxialLinkage
# we make it clad_feed.
<<: *component_clad
flags: CLAD FEED
latticeIDs: [2,3]
coolant:
shape: DerivedShape
material: Sodium
Expand Down Expand Up @@ -324,7 +358,7 @@ def test_densityConsistentWithComponentConstructor(self):
self.cs, self.blueprints
)
fuelBlock = a1[0]
clad = fuelBlock.getComponent(Flags.CLAD)
clad = fuelBlock.getComponent(Flags.CLAD, exact=True)

# now construct clad programmatically like in test_Blocks
programmaticBlock = test_blocks.buildSimpleFuelBlock()
Expand Down
Loading