Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup #1439

Merged
merged 15 commits into from
Oct 19, 2023
Merged

Misc cleanup #1439

merged 15 commits into from
Oct 19, 2023

Conversation

john-science
Copy link
Member

@john-science john-science commented Oct 18, 2023

What is the change?

  1. I removed some random code (AVAILABLE_MODIFICATION_NAMES)
  2. I removed an unused armi/physics/safety/settings.py file.
  3. I added requirements to our PR template.

Why is the change being made?

  • @keckler pointed out both (1) and (2) above.
  • (3) above came out of discussion with @albeanth

Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

doc/developer/tooling.rst Outdated Show resolved Hide resolved
@john-science
Copy link
Member Author

john-science commented Oct 19, 2023

I see the test failure. Oddly, it passes for me locally. But I'm looking at it.

Fixed.

@john-science john-science merged commit b67c22f into main Oct 19, 2023
23 checks passed
@john-science john-science deleted the misc_cleanup_john_20231017 branch October 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants