Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing sub-block grids #1947

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Fixing sub-block grids #1947

wants to merge 18 commits into from

Commits on Oct 10, 2024

  1. Save point

    @john-science
    john-science committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0a3764c View commit details
    Browse the repository at this point in the history

  2. linting

    @john-science
    john-science committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f19ea49 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @john-science
    john-science committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b79e2e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'main' into sub_block_grids

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ac34bb3 View commit details
    Browse the repository at this point in the history

  2. Adding release note

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b244c8a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Drew Johnson <anjohnson@terrapower.com>
    @john-science @drewj-tp
    john-science and drewj-tp authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    55c6715 View commit details
    Browse the repository at this point in the history

  4. Responding to comments

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dc73342 View commit details
    Browse the repository at this point in the history

  5. responding to reviewer: test docstrings

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1942ed1 View commit details
    Browse the repository at this point in the history

  6. Removed unused setting autoGenerateBlockGrids

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3facbc8 View commit details
    Browse the repository at this point in the history

  7. Anchroring grid to block - per reviewer

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    37dd62e View commit details
    Browse the repository at this point in the history

  8. Responding to comments - test refactor

    @john-science
    john-science committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0d55251 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into sub_block_grids

    @john-science
    john-science committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2f8a350 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into sub_block_grids

    @john-science
    john-science committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    349e406 View commit details
    Browse the repository at this point in the history

  3. On a hex lattice, sub-hex grids are rotated

    @john-science
    john-science committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7d8ab19 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into sub_block_grids

    @john-science
    john-science authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6141cc7 View commit details
    Browse the repository at this point in the history

  2. Making unit tests more stable

    @john-science
    john-science committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e8182dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sub_block_grids' of https://www.github.com/terrapower/armi 

     into sub_block_grids
    @john-science
    john-science committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4f8242a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Blocks are on same grid as Core

    @john-science
    john-science committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    86516c7 View commit details
    Browse the repository at this point in the history