Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Assembly.doubleResolution #1951

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Removing Assembly.doubleResolution #1951

merged 1 commit into from
Oct 14, 2024

Conversation

john-science
Copy link
Member

@john-science john-science commented Oct 14, 2024 •
edited
Loading

What is the change?

Removing the method Assembly.doubleResolution().

Why is the change being made?

Two reasons:

  1. The method is not used ANYWHERE.
  2. The method should probably be in some converter logic, not in the base Assembly class.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Oct 14, 2024
opotowsky
opotowsky approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy cleanup! 🧼

@john-science john-science merged commit cdf99f0 into main Oct 14, 2024
19 checks passed
@john-science john-science deleted the rm_double_res branch October 14, 2024 18:19
drewj-tp added a commit that referenced this pull request Oct 14, 2024
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/block-input-height
c1ec0e0 
* origin/main:
  Removing Assembly.doubleResolution (#1951)
  Adding DeprecationWarning for HistoryTrackerInterface (#1950)
  Removing tabulate as a dependency (#1948)
  Removing defunct comment from getPinCoordinates (#1931)
drewj-tp added a commit that referenced this pull request Oct 16, 2024
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/improve-assem-a…
d925b98 
…xial-linkage

* origin/main:
  New plugin hook for before reactor construction (#1945)
  Removing DoseResultsMapper (#1952)
  Adding logic so HexAssemblies are hexagonal (#1935)
  Adding Block.getInputHeight (#1927)
  Removing Assembly.doubleResolution (#1951)
  Adding DeprecationWarning for HistoryTrackerInterface (#1950)
  Removing tabulate as a dependency (#1948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @opotowsky