Fix ifopt continuous collision evaluator to distinguish CONTINUOUS and LVS_CONTINUOUS #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjoomen FYI |
Levi-Armstrong
merged commit 70d64d3
into
tesseract-robotics:master
4 of 6 checks passed
rjoomen
reviewed
Aug 1, 2023
| @@ -39,6 +39,10 @@ LVSContinuousCollisionEvaluator::LVSContinuousCollisionEvaluator( | |||
| , collision_config_(std::move(collision_config)) | |||
| , dynamic_environment_(dynamic_environment) | |||
| { | |||
| if (collision_config_->type != tesseract_collision::CollisionEvaluatorType::CONTINUOUS && | |||
There was a problem hiding this comment.
Is this check necessary? You don't do this in the LVSDiscreteCollisionEvaluator or the SingleTimestepCollisionEvaluator either. Not that it's bad to have an extra check, but for performance reasons. Or add the check everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this issue