Fix mismatched delete/free in OSQPModel #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-ReframeSystems
force-pushed
the
mismatched_free_fix
branch
from
1dbeadf
to
e10032c
Compare
Levi-Armstrong
requested changes
Apr 12, 2024
Do you mind if I change the clang format script to use a newer version of clang? Its using clang 8 at the moment but I can't get that on Ubuntu Jammy, I would like to change it to use the clang default version on the system. I'll update the PR with this and you can let me know if you have concerns with this. Also, happy to break that into a different PR if you want me to. |
Jack-ReframeSystems
force-pushed
the
mismatched_free_fix
branch
from
e10032c
to
10082c9
Compare
| @@ -1,2 +1,2 @@ | |||
| #!/bin/bash | |||
| find . -type f -regex '.*\.\(cpp\|hpp\|cc\|cxx\|h\|hxx\)' -exec clang-format-8 -style=file -i {} \; | |||
There was a problem hiding this comment.
Just for consistency please revert change.
|
replaced by #399 |
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were calling delete on the CSC matrix pointer but its malloc'd, we should be calling "free" instead. We also don't want to free any of the subfield (using something like
csc_spfree) since we manage the individual fields in OSQPModel vectors.