Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally enforce IMDSv2 on kitchen instances. #571

Closed
wants to merge 1 commit into from

Conversation

bobchaos
Copy link

@bobchaos bobchaos commented Dec 23, 2021

Description

Provides an option to enforce IMDSv2 on kitchen instances.

I considered exposing metadata_options directly but this brings it in line with the way it's done in the AWS console.

Issues Resolved

#479

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Signed-off-by: Marc Chamberland <Chamberland.Marc@gmail.com>
@bdwyertech
Copy link
Contributor

Blah, I just added support for similar -- I think we should expose metadata options as well, especially now that control of instance tags via metadata is also exposed via this config block.

https://aws.amazon.com/about-aws/whats-new/2022/01/instance-tags-amazon-ec2-instance-metadata-service/

@tas50
Copy link
Member

tas50 commented Mar 3, 2022

@bdwyertech
Copy link
Contributor

@bobchaos can you rebase this and add the docs to https://github.com/test-kitchen/test-kitchen/blob/main/docs/content/docs/drivers/aws.md

@tas50 the metadata addition would encompass this as well so you can prob close this out.

We need the whole block exposed because it is used to enable instance tags via metadata as well as the IMDSv2 hardening config.

@tas50 tas50 closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants