Allow running tests locally after deadline (change icons color when deadline has passed) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,12 +26,18 @@ | |||
| private TestRunHandler testRunHandler; | |||
| private Project project; | |||
|
|
|||
| private static final String GREEN_EYE = "testProjectGreen24.png"; | |||
| private static final String RED_EYE = "testProjectRed24.png"; | |||
There was a problem hiding this comment.
I would prefer more descriptive file and variable names, like ICON_TEST_RETURNABLE and icon_test_returnable.png etc.
|
Is this branch stale? If so, consider removing it as general clean up. |
jamo
force-pushed
the
master
branch
2 times, most recently
from
0f9659b
to
8fc669f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check if it works on your machine, I had some weird caching issues with changing the icon...