TH2-4916 #28
Closed
TH2-4916 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikita-Smirnov-Exactpro
approved these changes
Jun 2, 2023
Nikita-Smirnov-Exactpro
requested changes
Jun 2, 2023
added 2 commits
June 12, 2023 21:13
readme update version bump
Nikita-Smirnov-Exactpro
requested changes
Jun 22, 2023
| return MessageGroup(decodedMessages) | ||
| } | ||
|
|
||
| private fun decodeCsvData( |
There was a problem hiding this comment.
Could we extract some part of this method to a separate method to exclude copy past?
# Conflicts: # README.md # build.gradle
Nikita-Smirnov-Exactpro
approved these changes
Aug 1, 2023
| import com.exactpro.th2.common.grpc.MessageMetadata as ProtoMessageMetadata | ||
| import com.exactpro.th2.common.grpc.RawMessageMetadata as ProtoRawMessageMetadata | ||
| import com.exactpro.th2.common.grpc.MessageID as ProtoMessageID | ||
|
|
||
| import com.exactpro.th2.common.message.logId | ||
| import com.exactpro.th2.common.message.toJson | ||
| import com.exactpro.th2.common.schema.message.impl.rabbitmq.transport.* |
There was a problem hiding this comment.
Could you please avoid multiple imports
|
these changes were merged to TS-1127 is PR#29 ( #29 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transport protocol support