Use efficientgo/core/errors consistently #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
GiedriusS
approved these changes
Dec 2, 2022
fpetkovski
reviewed
Dec 2, 2022
| @@ -100,7 +101,7 @@ func (a *kAggregate) Next(ctx context.Context) ([]model.StepVector, error) { | |||
| a.paramOp.GetPool().PutVectors(args) | |||
|
|
|||
| if len(args) != len(in) { | |||
| return nil, fmt.Errorf("scalar argument not found") | |||
| return nil, errors.New("scalar argument not found") | |||
There was a problem hiding this comment.
What is the advantage of using errors.New instead of fmt.Errorf?
There was a problem hiding this comment.
This lib has stacktraces + some other advantages in API over Go stdlib one. It was implemented in Thanos first and later ported to efficientgo/core. For more details: thanos-io/thanos#5176 and thanos-io/thanos#5239
There was a problem hiding this comment.
Also effort on Thanos to port entire codebase to it: thanos-io/thanos#5382 (although now we might do it from efficientgo/core
fpetkovski
approved these changes
Dec 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we use
efficientgo/core/errorsconsistently, and adds lint rules for the same.