QFE: only log slow query, if it is a query endpoint #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
fix/qfe-only-log-slow-queries
branch
from
d0cf961
to
7608541
Compare
fpetkovski
reviewed
Oct 18, 2024
pedro-stanaka
force-pushed
the
fix/qfe-only-log-slow-queries
branch
2 times, most recently
from
7c3cea7
to
ac80d5b
Compare
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
fix/qfe-only-log-slow-queries
branch
from
ac80d5b
to
6ab96c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Query Frontend we log slow queries, but we don't differ from a call to
GET /favicon.icoto a proper query call.In this PR I am fixing this, by checking that the URL matches one of the Prometheus HTTP API prefixes for query via expression or query of metadata.
Changes