Fix VyOS Directives. #284
Open
Fix VyOS Directives. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. I installed Hyperglass today and encountered this behavior. I'll follow up to validate as soon as the fix is available! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the directives for VyOS to work with the current LTS release.
Related Issues
#245
This only fixes the syntax which will work with 1.4/1.5, while the issue wanted version specific syntax.
Motivation and Context
Because the directives do not work with VyOS. This fixes that.
Tests
Built fresh docker container with changes, tested all functions with v4 and v6 on VyOS 1.4.0 and 1.5 Rolling.