Chassis update #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Jan 6, 2024
auscompgeek
requested changes
Jan 6, 2024
auscompgeek
reviewed
Jan 6, 2024
components/chassis.py
Outdated
| @@ -396,7 +417,7 @@ def get_tilt_rate(self) -> float: | |||
|
|
|||
| @feedback | |||
| def get_drive_current(self) -> float: | |||
| return sum(abs(x.drive.getStatorCurrent()) for x in self.modules) | |||
| return sum(abs(x.drive.get_stator_current().value) for x in self.modules) | |||
There was a problem hiding this comment.
Eep, this is a code smell. The Chassis component should never have been reaching into the SwerveModule internals in the first place.
nit: add a SwerveModule.get_drive_current() -> float method
|
Is the sim working for you guys? Amber says navx is having issues, but I'm having issues with the sim not showing the TalonFX objects on one of its tabs |
outsidermm
force-pushed
the
chassis-update
branch
from
f0f8eae
to
a7e7ff7
Compare
It was resetting the magnet offset which we need
Tsunami014
force-pushed
the
chassis-update
branch
from
ea3c25f
to
6a062d4
Compare
Tsunami014
force-pushed
the
chassis-update
branch
from
6a062d4
to
390b272
Compare
auscompgeek
reviewed
Jan 13, 2024
robot.py
Outdated
| # print(pov) | ||
| if pov != -1: | ||
| joysticks[0] = 0 | ||
| joysticks[1] = 0 |
There was a problem hiding this comment.
What's with this joysticks list?
LucienMorey
force-pushed
the
chassis-update
branch
from
390b272
to
a3b71b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite chassis.py and physics.py using Pheonix 6 API and maintain TalonSRX support through Pheonix 5