Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendable encoder wrapper around TalonSRX #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@codecov-io
Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #12 into master will increase coverage by 0.44%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   76.98%   77.43%   +0.44%     
==========================================
  Files          18       19       +1     
  Lines         869      895      +26     
  Branches       81       81              
==========================================
+ Hits          669      693      +24     
- Misses        183      185       +2     
  Partials       17       17
Impacted Files Coverage Δ
robot.py 96.25% <ø> (-0.1%) ⬇️
pyswervedrive/module.py 94.4% <100%> (+0.16%) ⬆️
utilities/ctre.py 91.66% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5fffe4...82e84f5. Read the comment docs.

Copy link
Contributor

@james-ward james-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fizzlebert
Copy link
Contributor

Can you get the latest commits so that this can get merged in

@auscompgeek
Copy link
Member Author

I will only if someone will actually find this useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants