Vision latency #62
Open
Vision latency #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 85.31% 85.48% +0.16%
==========================================
Files 20 20
Lines 1369 1371 +2
Branches 133 134 +1
==========================================
+ Hits 1168 1172 +4
+ Misses 169 168 -1
+ Partials 32 31 -1
Continue to review full report at Codecov.
|
auscompgeek
reviewed
Mar 7, 2019
| self.ping_time = time.monotonic() | ||
| t = time.monotonic() | ||
| if t - self.ping_time > 0.5: | ||
| # Only ping every 500ms - don't keep smashing NetworkTables |
There was a problem hiding this comment.
Given that we're still constantly flushing NetworkTables here, the impact this will have on traffic is negligible.
The performance impact should also be close-to-negligible iff we have the latest wpilib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.