Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NodeJS 18.x on EL9 CI nodes #2071

Merged
merged 2 commits into from
Jun 27, 2024
Merged

use NodeJS 18.x on EL9 CI nodes #2071

merged 2 commits into from
Jun 27, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 14, 2024

@ehelms
Copy link
Member

ehelms commented May 14, 2024

Do we know for certain the tests will fail with 18? We could try it :)

@evgeni
Copy link
Member Author

evgeni commented May 14, 2024

Webpack 3 doesn't like the new Node afaik

@evgeni evgeni changed the title use NodeJS 18.x on CI nodes use NodeJS 18.x on EL9 CI nodes May 17, 2024
@evgeni
Copy link
Member Author

evgeni commented May 17, 2024

@ekohl @ehelms need a few brains here…

  • We have two kinds of Jenkins nodes: those labeled fast and those not labeled fast
  • Only fast ones get the heavy NodeJS involved jobs
  • We do not differentiate in Puppet, so both kinds get NodeJS installed
  • My idea was to keep the fast ones on EL8 until 3.9 is ded, and upgrade the "slow" ones already.
  • This can be done using this PR, but…

We do not need NodeSource anymore. CentOS has new enough NodeJS. And someone even made puppet-nodejs support DNF modules in voxpupuli/puppet-nodejs#488 (which is in 11.x) ;)
However, I am sure that flipping the existing setup to DNF modules would be a disaster.

How crazy would be to just stop managing NodeJS on EL8 completely, and instead use modules on EL9?
The existing Jenkins nodes would be unaffected and new ones on EL9 "cleaner".

@ehelms
Copy link
Member

ehelms commented May 17, 2024

  • Only fast ones get the heavy NodeJS involved jobs

I wonder if the reasoning behind this still holds true.

We do not need NodeSource anymore. CentOS has new enough NodeJS. And someone even made puppet-nodejs support DNF modules in voxpupuli/puppet-nodejs#488 (which is in 11.x) ;) However, I am sure that flipping the existing setup to DNF modules would be a disaster.

How crazy would be to just stop managing NodeJS on EL8 completely, and instead use modules on EL9? The existing Jenkins nodes would be unaffected and new ones on EL9 "cleaner".

Fine by me.

@evgeni
Copy link
Member Author

evgeni commented May 17, 2024

  • Only fast ones get the heavy NodeJS involved jobs

I wonder if the reasoning behind this still holds true.

It does. OSUOSL nodes are significantly slower than Conova/Netways.

@ehelms
Copy link
Member

ehelms commented May 17, 2024

It does. OSUOSL nodes are significantly slower than Conova/Netways.

I more meant to question whether our NodeJS testing has gotten faster as we use newer node and we've re-architected how it all gets built.

@evgeni
Copy link
Member Author

evgeni commented May 17, 2024

it's even an upgrade of the Node version, as the old repo is not updated anymore:

[vagrant@jenkins-node-el9 ~]$ node --version
v18.17.1

[vagrant@jenkins-node-el9 ~]$ node --version
v18.19.1

@evgeni
Copy link
Member Author

evgeni commented May 17, 2024

It does. OSUOSL nodes are significantly slower than Conova/Netways.

I more meant to question whether our NodeJS testing has gotten faster as we use newer node and we've re-architected how it all gets built.

Ah, well, I am not sure. I recall the original split was because of Ruby, not NodeJS and all tests run on the same jenkins node once they start?

@evgeni evgeni marked this pull request as ready for review May 17, 2024 12:43
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 is about to go EOL, but I'd also wait for all 3.9 jobs to be dropped from jenkins.jobs. Other than that, 👍

puppet/modules/jenkins_node/manifests/unittests.pp Outdated Show resolved Hide resolved
@evgeni
Copy link
Member Author

evgeni commented Jun 21, 2024

3.9 is about to go EOL, but I'd also wait for all 3.9 jobs to be dropped from jenkins.jobs. Other than that, 👍

This is scoped to EL9 only, so it won't affect current nodes anyway, but yeah.

@evgeni
Copy link
Member Author

evgeni commented Jun 27, 2024

We declared 3.9 dead, so I am merging this

@evgeni evgeni merged commit 3070a21 into master Jun 27, 2024
2 checks passed
@evgeni evgeni deleted the nodejs18 branch June 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants