explicitly resolve A/AAAA when pulling external IP from icanhazip #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipv4.icanhazip.com has an AAAA record, and ipv6 has an A record, which leads to both facts returning v6 addresses. while this is a missconfiguration on the side of icanhazip.com, we can prevent it from happening by forcing things at the resolver level.
ekohl
approved these changes
Sep 19, 2024
Yepp. It's a miss-config on the Cloudflare side. I've poked @major (he used to run this service) as I don't know who to poke at CF (who runs the service now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipv4.icanhazip.com has an AAAA record, and ipv6 has an A record, which
leads to both facts returning v6 addresses.
while this is a missconfiguration on the side of icanhazip.com, we can
prevent it from happening by forcing things at the resolver level.