Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete published rpms from the cache #2133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delete published rpms from the cache #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions puppet/modules/web/templates/deploy-stagingrpm.sh.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@

# Publish the repo - stderr/out redirect is required to stop the noninteractive shell from hanging
rsync --recursive --times --verbose --one-file-system --delete-after <%= $home %>/rsync_cache/$PROJECT/$RELEASE <%= $rpm_staging_directory %>/$PROJECT/ 2>&1 >/dev/null ;
# Cleanup - no need to keep the rpms
find <%= $home %>/rsync_cache/$PROJECT/$RELEASE -iname '*.rpm' -delete || true
2 changes: 2 additions & 0 deletions puppet/modules/web/templates/deploy-stagingyum.sh.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@

# Publish the repo - stderr/out redirect is required to stop the noninteractive shell from hanging
rsync --recursive --times --verbose --one-file-system --delete-after <%= @home %>/rsync_cache/$PROJECT/$RELEASE <%= @yum_directory %>/$PROJECT/ 2>&1 >/dev/null ;
# Cleanup - no need to keep the rpms
find <%= @home %>/rsync_cache/$PROJECT/$RELEASE -iname '*.rpm' -delete || true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is taken from the Debian cleanup. technically we could also yank the whole folder here with an rm -rf, what's you preference?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought we do not delete the cache so that we do not have to re-sync things that have already been synced and saved time and cost.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, today I had to delete things to be able to upload new things.
Like, there was a full 3.9 that we never will publish again in the cache.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it become part of retiring a release? Make it part of a procedure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly could, even tho I don't like that too much as such things tend to get forgotten.