add httpd #27
Merged
add httpd #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
httpd
branch
5 times, most recently
from
68ad560
to
27b4ccb
Compare
ehelms
reviewed
Oct 7, 2024
ehelms
reviewed
Oct 7, 2024
| @@ -0,0 +1,56 @@ | |||
| --- | |||
| - name: Install Apache httpd | |||
There was a problem hiding this comment.
We could use ubi9/httpd-24 but based on the list here we'd have to do some minor customization of it?
There was a problem hiding this comment.
We could, but what would be the benefit?
There was a problem hiding this comment.
Normalization of services, configurations mostly.
ehelms
reviewed
Oct 7, 2024
ehelms
reviewed
Oct 7, 2024
ehelms
reviewed
Oct 7, 2024
ehelms
reviewed
Oct 7, 2024
evgeni
force-pushed
the
httpd
branch
6 times, most recently
from
e4332be
to
4193c29
Compare
ehelms
reviewed
Oct 8, 2024
ehelms
reviewed
Oct 8, 2024
ehelms
approved these changes
Oct 10, 2024
ekohl
reviewed
Oct 10, 2024
Comment on lines
+17
to
+18
| path: /etc/httpd/conf.d/welcome.conf | ||
| state: absent |
There was a problem hiding this comment.
IIRC DNF will "helpfully" place this back after dnf upgrade. Should we keep the file but make sure the content is empty?
ekohl
reviewed
Oct 10, 2024
|
|
||
|
|
||
| def test_https_foreman_ping(host): | ||
| cmd = host.run('curl --cacert /root/certificates/certs/ca.crt --silent --output /dev/null --write-out \'%{http_code}\' https://quadlet.example.com/api/v2/ping') |
There was a problem hiding this comment.
I'd like to see more fixtures, like the CA file and hostname.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.