Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tests using packit #818

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Add basic tests using packit #818

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d03740a
Correct indenting for packit.yaml
ekohl Apr 4, 2024
33850ef
Stop syncing .packit.yaml
ekohl Apr 4, 2024
e4999c9
Add basic packit tests
ekohl Apr 4, 2024
d3fc944
[WIP] disable unrelated tests
ekohl Apr 4, 2024
7aabe3b
Provide an additional repository for packit
ekohl Apr 5, 2024
cded351
Use dnf variables
ekohl Apr 5, 2024
f1966fa
WIP
ekohl Apr 5, 2024
4579f30
WIP
ekohl Apr 5, 2024
6215d48
WIP
ekohl Apr 5, 2024
6b74203
WIP
ekohl Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .fmf/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1
24 changes: 0 additions & 24 deletions .github/workflows/ruby_tests.yml
View file
Open in desktop

This file was deleted.

15 changes: 8 additions & 7 deletions .packit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@ specfile_path: rubygem-foreman_maintain.spec

# add or remove files that should be synced
files_to_sync:
- rubygem-foreman_maintain.spec
- foreman_maintain.logrotate
- .packit.yaml
- rubygem-foreman_maintain.spec
- foreman_maintain.logrotate

# name in upstream package repository or registry (e.g. in PyPI)
upstream_package_name: foreman_maintain
Expand All @@ -30,14 +29,16 @@ jobs:
- job: copr_build
trigger: pull_request
targets:
rhel-8:
additional_modules: "foreman:el8"
additional_repos:
- https://yum.theforeman.org/releases/nightly/el8/x86_64/
rhel-9:
additional_repos:
- https://yum.theforeman.org/releases/nightly/el9/x86_64/
module_hotfixes: true
- job: tests
trigger: pull_request
targets:
rhel-9-x86_64:
distros:
- centos-stream-9

srpm_build_deps:
- wget
Expand Down
11 changes: 11 additions & 0 deletions plans/help.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
summary: Run with --help
prepare:
- how: ansible
playbook: playbooks/stagingyum.yml
- how: install
package:
# https://github.com/theforeman/foreman-packaging/pull/10670
- hostname
- foreman-maintain
execute:
- script: foreman-maintain --help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why --help triggers hostname?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's either this:

foreman_maintain/lib/foreman_maintain/concerns/system_helpers.rb

Lines 94 to 96 in cfbb8c4

def hostname
execute('hostname -f')
end

But more likely this:

foreman_maintain/lib/foreman_maintain/config.rb

Line 24 in cfbb8c4

@foreman_url = @options.fetch(:foreman_url, `hostname -f`.chomp)

That latter should really use block form:

@foreman_url = @options.fetch(:foreman_url) { `hostname -f`.chomp }

That way it doesn't execute hostname -f if a value is found.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could, in theory, use this PR to test both this PR and the theory? By including these pieces of code selectively commented out and removing the hostname requires. Kind of a fun experiment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#819. And there's already plenty of other things I'm trying to test. First I just want it to work.

11 changes: 11 additions & 0 deletions playbooks/stagingyum.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
- hosts: all
vars:
foreman_repositories_version: nightly
tasks:
- name: 'Foreman {{ foreman_repositories_version }} Staging repository'
yum_repository:
name: foreman-staging
description: "Foreman {{ foreman_repositories_version }} Staging Repository"
baseurl: "https://stagingyum.theforeman.org/foreman/{{ foreman_repositories_version }}/el{{ ansible_distribution_major_version }}/$basearch/"
gpgcheck: false