Add usage reports #928
Draft
Add usage reports #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the check so it can hold any arbitrary data. That is then used in the generate report command, that finds all checks tagged with report tag, executes them and gather their data for the final YAML creation. This commit also includes two examples of metrics that uses database as the Data source.
With this new child class, report checks can share helpers easily. Also the parent Check class, which is used elsewhere, does not need to be extended by the data storage.
Earlier, all Reports were also considered Checks, so they showed up in health checks. This change now fully isolates Reports and Checks while all the code is shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.