make pulpcore-(api|content) same priority as workers #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no good reason to have them at different priorities. additionally, having them at 10 actually hurts as it's the same priority as PostgreSQL which means the logs will be spammed by "connection refused" if the DB is shut down while api/content are still in the process of being shut-down (or booted up). this does *not* fix the segfaults problem -- but at least makes the logs a tad cleaner
|
Should also help with unclean shutdowns we've seen in https://community.theforeman.org/t/katello-nightly-rpm-pipeline-2155-failed/39693/3 |
ekohl
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no good reason to have them at different priorities.
additionally, having them at 10 actually hurts as it's the same priority
as PostgreSQL which means the logs will be spammed by "connection
refused" if the DB is shut down while api/content are still in the
process of being shut-down (or booted up).
this does not fix the segfaults problem -- but at least makes the logs
a tad cleaner