Fixes #37847 - Support Rails 7.0

theforeman · Oct 22, 2024 · 7ce103c · 7ce103c
1 parent 27b9b6f
commit 7ce103c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/app/helpers/job_invocations_helper.rb b/app/helpers/job_invocations_helper.rb
@@ -33,7 +33,7 @@ def preview_hosts(template_invocation)
   end
 
   def collapsed_preview(target)
-    title = target || 'N/A'
+    title = (target || 'N/A').to_s
     content_tag(:h5,
       :class => "expander collapsed out",
       :data => { :toggle => 'collapse',

diff --git a/app/models/concerns/foreman_remote_execution/errors_flattener.rb b/app/models/concerns/foreman_remote_execution/errors_flattener.rb
@@ -7,8 +7,8 @@ def flattened_validation_exception
     def flattened_errors
       errors = Hash.new { |h, k| h[k] = [] }
       # self.errors is ActiveModel::Errors, not Hash and doesn't have the #each_key method
-      self.errors.keys.each do |key|
-        messages = self.errors[key]
+      self.errors.attribute_names.each do |key|
+        messages = self.errors.messages_for(key)
         invalid_objects = invalid_objects_for_attribute(key)
         if invalid_objects.blank?
           errors[key] = messages

diff --git a/app/views/template_invocations/show.html.erb b/app/views/template_invocations/show.html.erb
@@ -55,7 +55,7 @@ end
   </div>
 
   <script>
-    <%= render :partial => 'refresh.js' %>
+    <%= render partial: 'refresh', formats: :js %>
   </script>
 <% else %>
   <%= _("Could not display data for job invocation.") %>

diff --git a/lib/foreman_remote_execution/engine.rb b/lib/foreman_remote_execution/engine.rb
@@ -4,10 +4,6 @@ module ForemanRemoteExecution
   class Engine < ::Rails::Engine
     engine_name 'foreman_remote_execution'
 
-    config.autoload_paths += Dir["#{config.root}/app/controllers/concerns"]
-    config.autoload_paths += Dir["#{config.root}/app/helpers/concerns"]
-    config.autoload_paths += Dir["#{config.root}/app/models/concerns"]
-
     # Precompile any JS or CSS files under app/assets/
     # If requiring files from each other, list them explicitly here to avoid precompiling the same
     # content twice.