Fixes #37986, #37982 - Fix UI Error when importing templates #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks @adamlazik1 for taking this further. I'd propose a bit different fix:
Instead of
:validation_errors => errors,try
:validation_errors => errors || {},
adamlazik1
force-pushed
the
fix-ui-error
branch
from
5081835
to
afa684e
Compare
|
@adamlazik1, yeah, sorry about that. It seems #190 was quite wrong, it should have been like this: https://github.com/ofedoren/foreman_templates/pull/1/files It also reverts changes in test file to the original state. |
Importing templates through UI causes an error and the page with import results does not load. Steps to Reproduce: 1. Have foreman instance with the templates plugin on nightly (error originates in one of the newest commits so it is not on stream yet). 2. Navigate to Hosts > Templates > Sync Templates 3. Import templates from https://github.com/theforeman/community-templates.git Actual behavior: The page with results does not load and two popups are displayed. One saying that templates have been imported succesfully and another saying that there has been an error. Expected behavior: Page with results loads normally and displays templates correctly.
adamlazik1
force-pushed
the
fix-ui-error
branch
from
afa684e
to
d813b0f
Compare
|
Thanks @ofedoren, I applied your patch and it fixes both the UI and the hammer issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing templates through UI causes an error and the page with import results does not load.
Steps to Reproduce:
Have foreman instance with the templates plugin on nightly (error originates in one of the newest commits so it is not on stream yet).
Navigate to Hosts > Templates > Sync Templates
Import templates from https://github.com/theforeman/community-templates.git
Actual behavior:
The page with results does not load and two popups are displayed. One saying that templates have been imported succesfully and another saying that there has been an error.
Expected behavior:
Page with results loads normally and displays templates correctly.
It appears that UI expects the error messages to be wrapped in array as opposed to being just string, and hammer (theforeman/hammer-cli-foreman-templates#15) expects an empty hash instead of nil when there are no errors.