move python 2.7 tests onto a container #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
py27
branch
2 times, most recently
from
98449e7
to
c87c807
Compare
ekohl
reviewed
Jul 12, 2023
There was a problem hiding this comment.
To drop Python 2.7 we need to make sure our CI runs on Python 3+. I think that means updating our nodes to EL8 or EL9, or using python3 explicitly. Can't we just ensure python3 is present on our nodes and change this line: https://github.com/theforeman/jenkins-jobs/blob/cb4dafc77d2f24893a1ff2fe786935e1d1c86ad7/theforeman.org/pipelines/lib/obal.groovy#L10
And then tell downstream to do the same.
evgeni
force-pushed
the
py27
branch
2 times, most recently
from
b4ca213
to
46369af
Compare
|
I've pulled in #360 which should make this one finally green. |
|
🍏 one big downside of the "run inside container" approach is: there is no caching happening, which adds quite some time, plus the test themself seem to be a tad slower, but I prefer this over accidental breakage |
ehelms
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.