Fix shebang in rpmspec_changelog #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
requested changes
Sep 28, 2023
| @@ -1,5 +1,3 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Ansible modules should have a shebang of #!/usr/bin/python so that some internal magic can replace it.
There was a problem hiding this comment.
None of our modules have a shebang, this was the only one. So... what are you saying we should do?
There was a problem hiding this comment.
ideally? set it for all. but probably change that one here, see it works, then change the others?
ehelms
force-pushed
the
drop-shebang
branch
from
69930e2
to
717acd1
Compare
evgeni
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.