Add support for rpmlint folder in the root of inventory_dir #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason to do it like this vs setting rpmlint_rc_file in the manifest? I would expect this to break when someone wants to set rc file in the manifest, but there is one in the folder? |
Odilhao
force-pushed
the
rpmlint-path
branch
from
6e3c322
to
883020f
Compare
This PRs adds support for one folder called rpmlint inside of the inventory_dir. With Pulp packaging going to Python 3.11, rpmlint is about to break when the Jenkins nodes start to use one ansible version that requires python 3.11 and install python3.11-libs, it will start to complain about the dist-utls deprecation in python 3.12+.
Odilhao
force-pushed
the
rpmlint-path
branch
from
883020f
to
a425c98
Compare
|
Sometimes I forget that we can use the manifest as one Ansible Inventory, I need to buy one rubber duck |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds support for one folder called rpmlint inside of the inventory_dir.
With Pulp packaging going to Python 3.11, rpmlint is about to break when the Jenkins nodes start to use one ansible version that requires python 3.11 and install python3.11-libs, it will start to complain about the
dist-utls deprecation in python 3.12+.