Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on obsah to pull in Ansible #382

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 28, 2023

obsah already pulls in either ansible or ansible-core, depending on the Python version. There's no need for obal itself to pull it in.

@evgeni
Copy link
Member

evgeni commented Dec 28, 2023

CI says "no"

@evgeni
Copy link
Member

evgeni commented Dec 28, 2023

6 failed, 195 passed

okay, not that bad.

@ekohl
Copy link
Member Author

ekohl commented Dec 28, 2023

At least this part fails:

- name: 'Copy upstream files'
ansible.posix.synchronize:
src: "{{ obal_tmp_dir }}/{{ upstream_directory }}/{{ item }}"
dest: "{{ inventory_dir }}/{{ package_base_dir }}/{{ inventory_hostname }}/"
with_items: "{{ upstream_files }}"

I think that causes most if not all failures.

@ekohl
Copy link
Member Author

ekohl commented Dec 28, 2023

Packaging wise we can depend on ansible-collection-ansible-posix but I'm not sure how to deal with pip based installations.

@evgeni
Copy link
Member

evgeni commented Dec 28, 2023

This escalated not as much as I have feared. What are we missing? :)

@ekohl
Copy link
Member Author

ekohl commented Dec 28, 2023

And copy works the same here? I don't know it well enough to say but I trust you

@evgeni
Copy link
Member

evgeni commented Dec 28, 2023

It doesn't sync, but it does recursively copy, which should be sufficient for our usecase.

And the usage should be covered by tests, so…

evgeni and others added 3 commits December 28, 2023 23:53
This removes the dependency on the posix collection, which isn't
included in ansible-core.
The yaml stdout callback is only available in the full Ansible, not
ansible-core.
obsah already pulls in either ansible or ansible-core, depending on the
Python version. There's no need for obal itself to pull it in.
@ekohl
Copy link
Member Author

ekohl commented Dec 28, 2023

Thanks! I've reordered the commits and changed the commit messages, but no actual code changes. I believe this is ready to go, but can't approve my own PR.

@ekohl ekohl merged commit 864503f into theforeman:master Dec 29, 2023
11 checks passed
@ekohl ekohl deleted the remove-ansible-dependency branch December 29, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants