Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only check repoclosure for noarch and x86_64 RPMs #387

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Apr 17, 2024

especially, don't check src, as they might have deps on development tooling, that is not present in normal lookaside repos.

this is only really neccessary for copr repos that ship both src and binary in the same repo.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way to exclude source packages, but I guess we'll need to do a big effort for non-x86_64 (like ARM) anyway. Perhaps at least introduce it as a parameter defaulting to x86_64?

especially, don't check src, as they might have deps on development
tooling, that is not present in normal lookaside repos.

this is only really neccessary for copr repos that ship both src and
binary in the same repo.
@evgeni
Copy link
Member Author

evgeni commented Apr 17, 2024

@ekohl like this?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, like this

@evgeni evgeni merged commit 4fe15b0 into master Apr 17, 2024
19 of 21 checks passed
@evgeni evgeni deleted the no-src-repoclosure branch April 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants