Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose pygam model penalties via spline_kwargs fixes #1126 #1132

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

bfurtwa
Copy link
Contributor

@bfurtwa bfurtwa commented Oct 20, 2023

IMPORTANT: Please search among the Pull requests before creating one.

Description

Expose pygam model penalties via spline_kwargs. Before it was set to penalties=["derivative", "l2"] in the code. Now, the user can change the default by using: spline_kwargs={'penalties':['derivative']}

How has this been tested?

Tested with my own data pipeline. Does not change default parameter.

Closes

closes #1126

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1132 (b8038a7) into main (c3ced63) will decrease coverage by 1.24%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   80.63%   79.39%   -1.24%     
==========================================
  Files          51       51              
  Lines        8483     8483              
  Branches     2218     1645     -573     
==========================================
- Hits         6840     6735     -105     
- Misses       1101     1205     +104     
- Partials      542      543       +1     
Files Coverage Δ
src/cellrank/models/_pygam_model.py 91.83% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bfurtwa ! Failing tests are related to #1128 , will be dealt with later.

@michalk8 michalk8 merged commit f3a6a0e into theislab:main Oct 24, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove L2 penalty from pygam models
2 participants