fix: tests

thenicekat · Apr 23, 2024 · 9f859c4 · 9f859c4
1 parent cc70fe7
commit 9f859c4
Show file tree

Hide file tree

Showing 4 changed files with 90 additions and 8 deletions.
diff --git a/backend/src/service/admin.service.ts b/backend/src/service/admin.service.ts
@@ -123,6 +123,8 @@ export const banUser = async (userEmailId: string): Promise<CustomReturn<User>>
     }
 }
 
+//changes Karma of a user
+//use sign=false to decrease   sign=true to increase
 export const deltaKarma =async (userEmailId: string, amount:number, sign:boolean): 
 Promise<CustomReturn<User>> => {
     try {
@@ -140,15 +142,15 @@ Promise<CustomReturn<User>> => {
         if (user.role == "admin") {
             return {
                 error: true,
-                data: "An admin cannot be fruit :)."
+                data: "Admin karma cannot be updated."
             }
         }
 
         if (sign==false) {
             if(user.karmaPoints<amount){
                 return{
                     error:true,
-                    data:"Stop, Stop! he is already dead"
+                    data:"Stop, Stop! he is already dead."
                 }
             }
             const punishedUser= await prisma.user.update({

diff --git a/backend/src/service/plot.service.ts b/backend/src/service/plot.service.ts
diff --git a/backend/tests/admin.test.ts b/backend/tests/admin.test.ts
@@ -1,7 +1,7 @@
 import { describe, expect } from "@jest/globals";
 import { prismaMock } from "./_mockdb";
 import { User } from ".prisma/client";
-import { getAllUsers, promoteUser, demoteUser, banUser } from "../src/service/admin.service";
+import { getAllUsers, promoteUser, demoteUser, banUser, deltaKarma} from "../src/service/admin.service";
 
 const user: User = {
     id: "1",
@@ -33,6 +33,16 @@ const na: User = {
     isPublic: true
 }
 
+const na2: User = {
+    id: "3",
+    name: "ben",
+    email: "hen@hen.com",
+    phoneNumber: "9898989898",
+    karmaPoints: 0,
+    role: "user",
+    isPublic: true
+}
+
 const bu: User= {
     id: "2",
     name: "ben",
@@ -43,6 +53,16 @@ const bu: User= {
     isPublic: true
 }
 
+const iku: User = {
+    id: "2",
+    name: "ben",
+    email: "ben@hen.com",
+    phoneNumber: "9898989898",
+    karmaPoints: 12,
+    role: "user",
+    isPublic: true
+}
+
 describe("Get all users", () => {
     it("should get all users", () => {
         prismaMock.user.findMany.mockResolvedValue([user]);
@@ -90,7 +110,7 @@ describe("demote admin to user", () => {
         prismaMock.user.findUnique.mockResolvedValue(a);
         prismaMock.user.update.mockResolvedValue(na);
 
-        expect(demoteUser(a.email)).resolves.toEqual({
+        expect(demoteUser(a.email,na2.email)).resolves.toEqual({
             error: false,
             data: na
         })
@@ -100,7 +120,7 @@ describe("demote admin to user", () => {
         prismaMock.user.findUnique.mockResolvedValue(a);
         prismaMock.user.update.mockRejectedValue(new Error("Some error occurred"));
 
-        expect(demoteUser(a.email)).resolves.toEqual({
+        expect(demoteUser(a.email,na2.email)).resolves.toEqual({
             error: true,
             data: "Some error occurred while demoting admin to user role"
         })
@@ -145,4 +165,62 @@ describe("ban user", () => {
             data: "Some error occurred while banning user."
         })
     })
+})
+
+describe("increase/decrease user karma", () => {
+    it("should increase karma", () => {
+        prismaMock.user.findUnique.mockResolvedValue(na);
+        prismaMock.user.update.mockResolvedValue(iku);
+
+        expect(deltaKarma(na.email,12,true)).resolves.toEqual({
+            error: false,
+            data: iku
+        })
+    })
+
+    it("should decrease karma", () => {
+        prismaMock.user.findUnique.mockResolvedValue(iku);
+        prismaMock.user.update.mockResolvedValue(na);
+
+        expect(deltaKarma(iku.email,12,false)).resolves.toEqual({
+            error: false,
+            data: na
+        })
+    })
+
+    it("should return error if target karma is negative", () => {
+        prismaMock.user.findUnique.mockResolvedValue(na);
+
+        expect(deltaKarma(na.email,12,false)).resolves.toEqual({
+            error: true,
+            data: "Stop, Stop! he is already dead."
+        })
+    })
+
+    it("should return an error if user does not exist", () => {
+
+        expect(banUser("random@random.com")).resolves.toEqual({
+            error: true,
+            data: "User does not exist."
+        })
+    })
+
+    it("should return error if user to be updated is an admin", () => {
+        prismaMock.user.findUnique.mockResolvedValue(a);
+
+        expect(deltaKarma(a.email,12,true)).resolves.toEqual({
+            error: true,
+            data: "Admin karma cannot be updated."
+        })
+    })
+
+    it("should return error if any error occured", () => {
+        prismaMock.user.findUnique.mockResolvedValue(na);
+        prismaMock.user.update.mockRejectedValue(new Error("Some error occurred"));
+
+        expect(deltaKarma(na.email,12,true)).resolves.toEqual({
+            error: true,
+            data: "Some error occurred while changing karma."
+        })
+    })
 })
diff --git a/backend/tests/user.test.ts b/backend/tests/user.test.ts
@@ -3,6 +3,8 @@ import { prismaMock } from "./_mockdb";
 import { getUserByEmail, newUser, getUserById } from "../src/service/user.service";
 import { updateUser } from "../src/service/user.service";
 
+
+
 describe("Create a new user", () => {
     it("should create a new user", () => {
         const user = {
@@ -250,7 +252,7 @@ describe("Fetch user data using id", () => {
 
         prismaMock.user.findUnique.mockResolvedValue(user);
 
-        expect(getUserById(user.id)).resolves.toEqual({
+        expect(getUserById(user.id,user.id)).resolves.toEqual({
             error: false,
             data: user
         });
@@ -269,7 +271,7 @@ describe("Fetch user data using id", () => {
 
         prismaMock.user.findUnique.mockResolvedValue(user);
 
-        expect(getUserById(user.id)).resolves.toEqual({
+        expect(getUserById(user.id,user.id)).resolves.toEqual({
             error: true,
             data: "User is not public."
         });
@@ -287,7 +289,7 @@ describe("Fetch user data using id", () => {
 
         prismaMock.user.findUnique.mockRejectedValue(new Error("Some error"));
 
-        expect(getUserById(user.id)).resolves.toEqual({
+        expect(getUserById(user.id,user.id)).resolves.toEqual({
             error: true,
             data: null
         });