Add google auth setup #5
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9654157 | Triggered | Google OAuth2 Keys | f68e51f | backend/config/default.ts | View secret |
| 9654157 | Triggered | Google OAuth2 Keys | c42b0ee | backend/config/default.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Check naming of the PRs. Also restructure them into service and route |
| } | ||
| ); | ||
| return res.data; | ||
| } catch (error: any) { |
There was a problem hiding this comment.
remove unnecessary comments ig
|
@Divyateja04 we should merge after the secrets are removed |
backend/config/default.ts
Outdated
There was a problem hiding this comment.
can't we use constants.ts for this tho
backend/src/index.ts
Outdated
| @@ -37,6 +40,9 @@ app.use(session({ | |||
| // Add routes | |||
| app.use('/hello', helloRouter) | |||
| app.use('/posts', postsRouter) | |||
| app.use("/api/sessions/oauth/google", gauthRouter) | |||
| app.use('/user/signup',userRouter) | |||
There was a problem hiding this comment.
this should be /user not /user/signup
backend/src/routes/user.route.ts
Outdated
|
|
||
| export const userRouter = Router(); | ||
|
|
||
| userRouter.post("/user/signup", async (req, res) => { |
There was a problem hiding this comment.
make this /signup not /user/signup.
No description provided.