-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Prevent Poetry compilation problems in non-Linux environments #48
Draft
assouktim
wants to merge
2
commits into
theopenconversationkit:master
Choose a base branch
from
CreditMutuelArkea:fix/poetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,32 @@ | ||
FROM python:3.11-alpine | ||
|
||
# Set environment variables | ||
ENV PYTHONUNBUFFERED=1 \ | ||
POETRY_VERSION=1.8.3 \ | ||
# Poetry virtual environments are disabled to install packages globally inside the container. | ||
POETRY_VIRTUALENVS_CREATE=false \ | ||
POETRY_NO_INTERACTION=1 \ | ||
# The Poetry cache directory is set to reduce repeated downloads in future builds. | ||
POETRY_CACHE_DIR='/var/cache/pypoetry' | ||
|
||
# Install Poetry | ||
RUN pip install "poetry==$POETRY_VERSION" | ||
|
||
# Set working directory in the container | ||
WORKDIR /app | ||
|
||
COPY target/requirements.txt . | ||
# Copy only the necessary files to the Docker container | ||
COPY target/server/pyproject.toml /app/ | ||
COPY target/server/poetry.lock /app/ | ||
|
||
RUN pip install --no-cache-dir -r requirements.txt | ||
# Install dependencies | ||
RUN poetry install --no-root --no-dev --verbose | ||
|
||
COPY target/gen_ai_orchestrator gen_ai_orchestrator/ | ||
# Copy the rest of the project files into the container | ||
COPY target/server/src/gen_ai_orchestrator gen_ai_orchestrator/ | ||
|
||
# Expose port for web app | ||
EXPOSE 8000 | ||
|
||
CMD ["uvicorn", "gen_ai_orchestrator.main:app", "--host", "0.0.0.0", "--port", "8000", "--log-config", "gen_ai_orchestrator/configurations/logging/config.ini"] | ||
# Run the application | ||
CMD ["uvicorn", "gen_ai_orchestrator.main:app", "--host", "0.0.0.0", "--port", "8000", "--log-config", "gen_ai_orchestrator/configurations/logging/config.ini"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ | |
<groupId>io.fabric8</groupId> | ||
<artifactId>docker-maven-plugin</artifactId> | ||
<configuration> | ||
<verbose>true</verbose> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should remove it, use it only for debug purposes. |
||
<images> | ||
<image> | ||
<name>tock/gen-ai-orchestrator-server:${project.version}</name> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure fabrikIO correctly support it we it would be better do use multi-staged docker file : https://medium.com/@albertazzir/blazing-fast-python-docker-builds-with-poetry-a78a66f5aed0#:~:text=Using%20Docker%20multi%2Dstage%20builds
It could be done in an other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a docker build problems (proxy/repository). It would be better to deal with this later.