golangci updates for speed #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golanglemonade
force-pushed
the
golangci-updates
branch
from
fcd9a6b
to
906f20f
Compare
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
golanglemonade
force-pushed
the
golangci-updates
branch
from
57ab405
to
998b75d
Compare
|
matoszz
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now locally takes:
vs. before the changes:
CI is passing in about 7-8 minutes.
Changes:
test: falsewill now include all tests files from the linter.fastandfixfrom the ci run. The first run offastis always slower, its not recommended to run in ci. Andfixshould never be run in CI because the changes need to be pushed to the branch.