-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "state" parameter of error responses #1298
Open
hafezdivandari
wants to merge
18
commits into
thephpleague:master
Choose a base branch
from
hafezdivandari:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please can you provide some information about why you want to add this change? Thank you |
I added description I hope it is clear enough. |
Just merged |
hafezdivandari
changed the title
Use fragment for error response on implicit grant
Fix "state" parameter of error responses
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 6749 on error response of the implicit grant, the authorization server should add parameters to the fragment component of the redirection URI and the
state
parameter is required if it was present on the request.There already 2 error responses that have redirect URI:
Invalid_scope
:state
parameter when redirecting. This PR fixes this on both 'auth code' and 'implicit' grants.http://example.com/callback?error=access_denied&error_description=...
http://example.com/callback?state=123&error=access_denied&error_description=...
http://example.com/callback#error=access_denied&error_description=...
http://example.com/callback#state=123&error=access_denied&error_description=...
access_denied
: This error response does include thestate
parameter when redirecting as expected, but when using implicit grant, the error'sstate
parameter is on query string and other parameters were on fragment component. This PR fixes this.http://example.com/callback?state=123#error=access_denied&error_description=...
http://example.com/callback#state=123&error=access_denied&error_description=...