Fix explicit redirect uri not being optional in authorization code grant #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses thephpleague#1418 Also fixed event emitter trait not storing automatically created instance (addresses thephpleague#1422)
ls-sean-fraser
force-pushed
the
fix-optional-redirect-uri
branch
from
f328e5d
to
422f9e0
Compare
This was
linked to
issues
Aug 4, 2024
|
Thanks for this @ls-sean-fraser. Looks great. I've double checked everything and all stands up. Only change I made was to one of the test names to make it more verbose as it took me a while to work out what it was testing. Also added in a changelog entry. Thanks for your PR and issue posting! |
|
Thank you @Sephster! Happy to help! Can you tag a patch version so that we can pull the fix? |
|
Hi @Sephster, still waiting for a new patch version to be tagged with these fixes |
|
Apologies. Will get to this asap. Been snowed under at work |
|
I know the feeling 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests added for all changes