Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenPaymaster v3 #101

Merged
merged 3 commits into from
Nov 22, 2024
Merged

TokenPaymaster v3 #101

merged 3 commits into from
Nov 22, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 20, 2024

Lisk LSK Paymaster
Base USDC Paymaster
Celo CUSD Paymaster


PR-Codex overview

This PR primarily focuses on adding support for new token paymasters (CELO_CUSD and LISK_LSK) in the SmartWallet implementation, along with updating the PaymasterAddress for BASE_USDC. It also modifies some commented-out code to reflect these changes.

Detailed summary

  • Added support for CELO_CUSD and LISK_LSK token paymasters in SmartWallet.
  • Updated PaymasterAddress for BASE_USDC.
  • Changed logic for determining entryPoint based on tokenPaymaster.
  • Adjusted PaymasterPostOpGasLimit calculation.
  • Updated comments and code examples for CELO_CUSD and LISK_LSK.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.21%. Comparing base (7404406) to head (629f845).

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   78.11%   78.21%   +0.09%     
==========================================
  Files          28       28              
  Lines        4424     4444      +20     
  Branches      621      622       +1     
==========================================
+ Hits         3456     3476      +20     
  Misses        803      803              
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@0xFirekeeper 0xFirekeeper merged commit be34729 into main Nov 22, 2024
1 check failed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/tokenpaymaster-v3 branch November 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants